Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented MVVM on profile_page.dart #790

Merged

Conversation

rutvik11062000
Copy link
Contributor

What kind of change does this PR introduce?
Structurally added Model-View-ViewModel layers in Profile page.

Did you add tests for your changes?
Yes, Updated the profile organization page test.
If relevant, did you update the documentation?

Summary
For ease of testing and separation of different layers to make a logical data flow and error handling.

Does this PR introduce a breaking change?
No.

Other information
There was an exception occur while we tap on "leave this organization" it was already present before these PR changes, can be handle in different issue.
Resolves: #766

@Sagar2366
Copy link
Contributor

@rutvik11062000 linter check is failing, have a look, also resolve conflicts on PR.

@palisadoes palisadoes merged commit 56d3309 into PalisadoesFoundation:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MVVM implementation for Profile Page (profile_page.dart).
3 participants